Skip to content

Commit

Permalink
Moved test for online alter in connect to separate test
Browse files Browse the repository at this point in the history
This was needed as mtr --embedded connect.alter failed as online is
ignored for embedder server.
This fixes a wrong commit 30c965f
  • Loading branch information
montywi committed Feb 26, 2024
1 parent aea1af0 commit 058510a
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 16 deletions.
8 changes: 0 additions & 8 deletions storage/connect/mysql-test/connect/r/alter.result
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,3 @@ line
2Two
3Three
DROP TABLE t1, t2;
# MDEV-31777 ER_GET_ERRNO upon online alter with concurrent DML on
# CONNECT table
CREATE TABLE t (a INT) ENGINE=CONNECT TABLE_TYPE=DOS;
Warnings:
Warning 1105 No file name. Table will use t.dos
ALTER TABLE t FORCE, ALGORITHM=COPY, LOCK=NONE;
ERROR 0A000: LOCK=NONE is not supported. Reason: CONNECT. Try LOCK=SHARED
DROP TABLE t;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# MDEV-31777 ER_GET_ERRNO upon online alter with concurrent DML on
# CONNECT table
CREATE TABLE t (a INT) ENGINE=CONNECT TABLE_TYPE=DOS;
Warnings:
Warning 1105 No file name. Table will use t.dos
ALTER TABLE t FORCE, ALGORITHM=COPY, LOCK=NONE;
ERROR 0A000: LOCK=NONE is not supported. Reason: CONNECT. Try LOCK=SHARED
DROP TABLE t;
8 changes: 0 additions & 8 deletions storage/connect/mysql-test/connect/t/alter.test
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,6 @@ SELECT * from t2;

DROP TABLE t1, t2;


--echo # MDEV-31777 ER_GET_ERRNO upon online alter with concurrent DML on
--echo # CONNECT table
CREATE TABLE t (a INT) ENGINE=CONNECT TABLE_TYPE=DOS;
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
ALTER TABLE t FORCE, ALGORITHM=COPY, LOCK=NONE;
DROP TABLE t;

#
# Clean up
#
Expand Down
9 changes: 9 additions & 0 deletions storage/connect/mysql-test/connect/t/alter_not_embedded.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Disable test for embedded as 'online' is ignored
--source include/not_embedded.inc

--echo # MDEV-31777 ER_GET_ERRNO upon online alter with concurrent DML on
--echo # CONNECT table
CREATE TABLE t (a INT) ENGINE=CONNECT TABLE_TYPE=DOS;
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
ALTER TABLE t FORCE, ALGORITHM=COPY, LOCK=NONE;
DROP TABLE t;

0 comments on commit 058510a

Please sign in to comment.