Skip to content

Commit

Permalink
MDEV-33642: MemorySanitizer: SEGV on unknown address on shutdown
Browse files Browse the repository at this point in the history
signal_hand(): Remove the cmake -DWITH_DBUG_TRACE=ON instrumentation.
It can cause a crash on shutdown when the only other thread is
waiting in wait_for_signal_thread_to_end().
  • Loading branch information
dr-m committed Mar 11, 2024
1 parent 09ea2dc commit 0a9cec2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sql/mysqld.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3209,7 +3209,6 @@ pthread_handler_t signal_hand(void *arg __attribute__((unused)))
sigset_t set;
int sig;
my_thread_init(); // Init new thread
DBUG_ENTER("signal_hand");
signal_thread_in_use= 1;

/*
Expand Down Expand Up @@ -3263,7 +3262,6 @@ pthread_handler_t signal_hand(void *arg __attribute__((unused)))
{
DBUG_PRINT("quit",("signal_handler: calling my_thread_end()"));
my_thread_end();
DBUG_LEAVE; // Must match DBUG_ENTER()
signal_thread_in_use= 0;
pthread_exit(0); // Safety
return 0; // Avoid compiler warnings
Expand Down

0 comments on commit 0a9cec2

Please sign in to comment.