Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDEV-6610 Assertion `thd->is_error() || thd->killed' failed in mysql_…
…execute_command on executing an SP with repeated CREATE TABLE .. SELECT the bug was introduced by CREATE OR REPLACE implementation. CREATE IF NOT EXISTS ... SELECT was returning an error status to the caller, while sending an ok packet to the user. SP code was not prepared for that and trusted that error status means an error.
- Loading branch information
Sergei Golubchik
committed
Sep 6, 2014
1 parent
3da7619
commit 0c148e4
Showing
3 changed files
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
CREATE TABLE t1 (i INT); | ||
SET @a = 2; | ||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
Warnings: | ||
Note 1050 Table 't2' already exists | ||
DROP TABLE t2; | ||
CREATE PROCEDURE sp() | ||
BEGIN | ||
REPEAT | ||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
SET @a = @a - 1; | ||
UNTIL @a = 0 | ||
END REPEAT ; | ||
END | | ||
CALL sp(); | ||
Warnings: | ||
Note 1050 Table 't2' already exists | ||
DROP PROCEDURE sp; | ||
DROP TABLE t1, t2; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# | ||
# MDEV-6610 Assertion `thd->is_error() || thd->killed' failed in mysql_execute_command on executing an SP with repeated CREATE TABLE .. SELECT | ||
# | ||
CREATE TABLE t1 (i INT); | ||
SET @a = 2; | ||
|
||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
DROP TABLE t2; | ||
|
||
--delimiter | | ||
CREATE PROCEDURE sp() | ||
BEGIN | ||
REPEAT | ||
CREATE TABLE IF NOT EXISTS t2 (i INT) ENGINE = MyISAM | ||
AS SELECT * FROM t1; | ||
SET @a = @a - 1; | ||
UNTIL @a = 0 | ||
END REPEAT ; | ||
END | | ||
--delimiter ; | ||
|
||
CALL sp(); | ||
|
||
DROP PROCEDURE sp; | ||
DROP TABLE t1, t2; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters