Skip to content

Commit

Permalink
Make sure to recompile the feedback plugin for EMBEDDED
Browse files Browse the repository at this point in the history
On OS X with clang 7.3.0 running any test as embedded crashes. As
libfeedback was not compiled with embedded, we had 2 notions of THD,
with different number of members. When calling inline functions defined in
sql_class.h, the functions were defined for 1 THD but called on an
object that is different. This resulted in erroneous data being returned
and shortly after, a crash within the alloc_query() function.

Recompile the feedback plugin for the embedded server specifically to
not have such symbol conflicts.
  • Loading branch information
cvicentiu committed Sep 27, 2016
1 parent e226276 commit 0e47223
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugin/feedback/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ ENDIF(WIN32)

MYSQL_ADD_PLUGIN(FEEDBACK ${FEEDBACK_SOURCES}
LINK_LIBRARIES ${SSL_LIBRARIES}
${MAYBE_STATIC_ONLY} DEFAULT)
${MAYBE_STATIC_ONLY} RECOMPILE_FOR_EMBEDDED DEFAULT)

0 comments on commit 0e47223

Please sign in to comment.