Skip to content

Commit

Permalink
MDEV-25745: Not applying INSERT_REUSE_REDUNDANT
Browse files Browse the repository at this point in the history
page_apply_insert_redundant(): Correct a condition that would
occasionally fail when recovering changes for the change buffer tree
(where extra_size and data_size can vary wildly).

This was broken in commit 138cbec
(MDEV-21724).
  • Loading branch information
dr-m committed May 31, 2021
1 parent 6ca0654 commit 139333a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/innobase/page/page0cur.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2443,7 +2443,7 @@ bool page_apply_insert_redundant(const buf_block_t &block, bool reuse,
if (UNIV_UNLIKELY(free_rec - fextra_size < heap_bot))
goto corrupted;
const ulint fdata_size= rec_get_data_size_old(free_rec);
if (UNIV_UNLIKELY(free_rec + data_size > heap_top))
if (UNIV_UNLIKELY(free_rec + fdata_size > heap_top))
goto corrupted;
if (UNIV_UNLIKELY(extra_size + data_size > fextra_size + fdata_size))
goto corrupted;
Expand Down

0 comments on commit 139333a

Please sign in to comment.