Skip to content

Commit

Permalink
MDEV-25666: After backup, "Could not find a valid tablespace file"
Browse files Browse the repository at this point in the history
Ever since MDEV-18518 made DDL operations mostly crash-safe inside InnoDB,
it became obvious that Mariabackup might not be entirely safe with regard to
concurrent DDL operations.

check_if_skip_table(): Do not skip files whose name starts with #sql.
We cannot know whether a DDL operation is in progress and the table
might in fact be needed later.
  • Loading branch information
dr-m committed May 14, 2021
1 parent 7750cda commit 1c5ae99
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions extra/mariabackup/xtrabackup.cc
Expand Up @@ -2618,10 +2618,6 @@ check_if_skip_table(
tbname = ptr + 1;
}

if (strncmp(tbname, tmp_file_prefix, tmp_file_prefix_length) == 0) {
return TRUE;
}

if (regex_exclude_list.empty() &&
regex_include_list.empty() &&
!tables_include_hash.array &&
Expand Down

0 comments on commit 1c5ae99

Please sign in to comment.