Skip to content

Commit

Permalink
MDEV-6567: Raw debug output in the error log.
Browse files Browse the repository at this point in the history
Removed raw debug output when no error on OS operation has not happened.
  • Loading branch information
Jan Lindström committed Aug 13, 2014
1 parent e2b2bde commit 2062c9a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
9 changes: 6 additions & 3 deletions storage/innobase/os/os0file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -802,16 +802,19 @@ os_file_handle_error_cond_exit(
is better to ignore on_error_silent and print an error message
to the log. */

if (should_exit || !on_error_silent) {
fprintf(stderr,
" InnoDB: Operation %s to file %s and at line %ld\n",
operation, file, line);
}

if (should_exit || !on_error_silent) {
ib_logf(IB_LOG_LEVEL_ERROR, "File %s: '%s' returned OS "
"error " ULINTPF ".%s", name ? name : "(unknown)",
operation, err, should_exit
? " Cannot continue operation" : "");
}

fprintf(stderr,
" InnoDB: at file %s and at line %ld\n", file, line);

if (should_exit) {
exit(1);
}
Expand Down
7 changes: 5 additions & 2 deletions storage/xtradb/os/os0file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -871,8 +871,11 @@ os_file_handle_error_cond_exit(
is better to ignore on_error_silent and print an error message
to the log. */

fprintf(stderr,
" InnoDB: at file %s and at line %ld\n", file, line);
if (should_exit || !on_error_silent) {
fprintf(stderr,
" InnoDB: Operation %s to file %s and at line %ld\n",
operation, file, line);
}

if (should_exit || !on_error_silent) {
ib_logf(IB_LOG_LEVEL_ERROR, "File %s: '%s' returned OS "
Expand Down

0 comments on commit 2062c9a

Please sign in to comment.