Skip to content

Commit

Permalink
MDEV-17917 MTR: fixed race conditions in perfschema.socket_connect, m…
Browse files Browse the repository at this point in the history
…ain.connect
  • Loading branch information
vaintroub committed Dec 6, 2018
1 parent 6491c59 commit 2a2e8ea
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 21 deletions.
13 changes: 0 additions & 13 deletions mysql-test/suite/perfschema/r/socket_connect.result
Expand Up @@ -159,19 +159,6 @@ Expect 1

# 6.1 Verify that there are no TCP/IP connections in the socket instance table

SELECT COUNT(*) = 0 AS 'Expect 1'
FROM performance_schema.socket_instances
WHERE EVENT_NAME LIKE '%client_connection%'
AND OBJECT_INSTANCE_BEGIN <> @default_object_instance_begin
AND (IP LIKE '%127.0.0.1' OR IP LIKE '%::1');
Expect 1
1

# 6.2 Verify that there are no TCP/IP connections in the summary instance table

SELECT COUNT(*) = 0 AS 'Expect 1'
FROM performance_schema.socket_summary_by_instance
WHERE EVENT_NAME LIKE '%client_connection%'
AND OBJECT_INSTANCE_BEGIN <> @default_object_instance_begin;
Expect 1
1
9 changes: 6 additions & 3 deletions mysql-test/suite/perfschema/t/socket_connect.test
Expand Up @@ -273,18 +273,21 @@ WHERE EVENT_NAME LIKE '%client_connection%'
--echo
--echo # 6.1 Verify that there are no TCP/IP connections in the socket instance table
--echo
eval SELECT COUNT(*) = 0 AS 'Expect 1'
let $wait_condition=
SELECT COUNT(*) = 0 AS 'Expect 1'
FROM performance_schema.socket_instances
WHERE EVENT_NAME LIKE '%client_connection%'
AND OBJECT_INSTANCE_BEGIN <> @default_object_instance_begin
AND $ip_localhost;
--source include/wait_condition.inc

--echo
--echo # 6.2 Verify that there are no TCP/IP connections in the summary instance table
--echo
eval SELECT COUNT(*) = 0 AS 'Expect 1'
let $wait_condition=
SELECT COUNT(*) = 0 AS 'Expect 1'
FROM performance_schema.socket_summary_by_instance
WHERE EVENT_NAME LIKE '%client_connection%'
AND OBJECT_INSTANCE_BEGIN <> @default_object_instance_begin;

--source include/wait_condition.inc
exit;
7 changes: 2 additions & 5 deletions mysql-test/t/connect.test
Expand Up @@ -253,11 +253,8 @@ let $wait_condition =

--echo
--echo # -- Waiting for connections to close...
let $wait_condition =
SELECT COUNT(*) = 1
FROM information_schema.processlist
WHERE db = 'test';
--source include/wait_condition.inc
let $count_sessions=1;
--source include/wait_until_count_sessions.inc

--echo
DROP USER mysqltest_u1@localhost;
Expand Down

0 comments on commit 2a2e8ea

Please sign in to comment.