MDEV-29543 Windows: Unreadable dlerror() message on localized OS

vaintroub · vaintroub · commit 32bab2ce0518 · 2022-09-15T09:39:05.000+02:00
Force using english for error messages (i.e ASCII) to avoid encoding
mixup.
diff --git a/include/my_global.h b/include/my_global.h
@@ -1094,7 +1094,7 @@ static inline char *dlerror(void)
 {
   static char win_errormsg[2048];
   FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM,
-    0, GetLastError(), 0, win_errormsg, 2048, NULL);
+    0, GetLastError(),  MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), win_errormsg, 2048, NULL);
   return win_errormsg;
 }
 #define HAVE_DLOPEN 1

Original file line number	Diff line number	Diff line change
`@@ -1094,7 +1094,7 @@ static inline char *dlerror(void)`
`1094`	`1094`	`{`
`1095`	`1095`	`static char win_errormsg[2048];`
`1096`	`1096`	`FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM,`
`1097`		`- 0, GetLastError(), 0, win_errormsg, 2048, NULL);`
	`1097`	`+ 0, GetLastError(), MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), win_errormsg, 2048, NULL);`
`1098`	`1098`	`return win_errormsg;`
`1099`	`1099`	`}`
`1100`	`1100`	`#define HAVE_DLOPEN 1`