Skip to content

Commit

Permalink
MDEV-21462 main.processlist_notembedded fails to clean up
Browse files Browse the repository at this point in the history
Replace the 30-second sleep in the test with proper
DEBUG_SYNC interlocking.
  • Loading branch information
dr-m committed May 6, 2020
1 parent 6a31aea commit 459e861
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion mysql-test/r/processlist_notembedded.result
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#
# MDEV-20466: SHOW PROCESSLIST truncates query text on \0 bytes
#
SET DEBUG_SYNC= 'before_join_optimize SIGNAL in_sync';
SET DEBUG_SYNC= 'before_join_optimize SIGNAL in_sync WAIT_FOR go';
SET DEBUG_SYNC= 'now WAIT_FOR in_sync';
SET DEBUG_SYNC= 'now SIGNAL go';
SET DEBUG_SYNC = 'RESET';
End of 5.5 tests
9 changes: 7 additions & 2 deletions mysql-test/t/processlist_notembedded.test
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
source include/have_debug.inc;
source include/have_debug_sync.inc;
source include/not_embedded.inc;
source include/count_sessions.inc;

--echo #
--echo # MDEV-20466: SHOW PROCESSLIST truncates query text on \0 bytes
Expand All @@ -10,9 +11,9 @@ connect (con1,localhost,root,,);

connection con1;

let $q= `select CONCAT("SELECT user FROM mysql.user WHERE user ='some", CHAR(0), "' or sleep (30)")`;
let $q= `select CONCAT("SELECT user sleep FROM mysql.user WHERE user ='some", CHAR(0), "'")`;

SET DEBUG_SYNC= 'before_join_optimize SIGNAL in_sync';
SET DEBUG_SYNC= 'before_join_optimize SIGNAL in_sync WAIT_FOR go';
--disable_query_log
--send_eval $q;
--enable_query_log
Expand All @@ -27,8 +28,12 @@ let SEARCH_PATTERN=sleep;
source include/search_pattern_in_file.inc;
remove_file $MYSQLTEST_VARDIR/tmp//MDEV-20466.text;

SET DEBUG_SYNC= 'now SIGNAL go';

disconnect con1;

SET DEBUG_SYNC = 'RESET';

source include/wait_until_count_sessions.inc;

--echo End of 5.5 tests

0 comments on commit 459e861

Please sign in to comment.