Skip to content

Commit

Permalink
Fix test failures on s390x in test following main.column_compression_rpl
Browse files Browse the repository at this point in the history
The problem is the test is skipped after sourcing include/master-slave.inc.
This leaves the slave threads running after the test is skipped, causing a
following test to fail during rpl setup.

Also rename have_normal_bzip.inc to the more appropriate _zlib.

Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
  • Loading branch information
knielsen committed Jan 12, 2024
1 parent 8a763c0 commit 5b0a415
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
@@ -1,9 +1,9 @@
--source include/have_compress.inc

# Test that the system is using the default/standard bzip library.
# Test that the system is using the default/standard zlib library.
# If not, we have to skip the test as the compression lengths displayed
# in the test will not match the results from used compression library.

if (`select length(COMPRESS(space(5000))) != 33`) {
skip Test skipped as standard bzip is needed;
skip Test skipped as standard zlib is needed;
}
2 changes: 1 addition & 1 deletion mysql-test/main/column_compression.test
@@ -1,6 +1,6 @@
--source include/have_innodb.inc
--source include/have_csv.inc
--source include/have_normal_bzip.inc
--source include/have_normal_zlib.inc

let $MYSQLD_DATADIR= `select @@datadir`;

Expand Down
2 changes: 1 addition & 1 deletion mysql-test/main/column_compression_rpl.test
@@ -1,6 +1,6 @@
--source include/have_innodb.inc
--source include/have_normal_zlib.inc
--source include/master-slave.inc
--source include/have_normal_bzip.inc

--let $engine_type= myisam
--let $engine_type2= innodb
Expand Down
2 changes: 1 addition & 1 deletion mysql-test/main/func_compress.test
@@ -1,5 +1,5 @@
-- source include/have_compress.inc
-- source include/have_normal_bzip.inc
-- source include/have_normal_zlib.inc
#
# Test for compress and uncompress functions:
#
Expand Down
2 changes: 1 addition & 1 deletion mysql-test/main/mysqlbinlog_row_compressed.test
Expand Up @@ -4,7 +4,7 @@

--source include/have_log_bin.inc
--source include/have_binlog_format_row.inc
--source include/have_normal_bzip.inc
--source include/have_normal_zlib.inc

#
#
Expand Down
2 changes: 1 addition & 1 deletion mysql-test/main/mysqlbinlog_stmt_compressed.test
Expand Up @@ -4,7 +4,7 @@

--source include/have_log_bin.inc
--source include/have_binlog_format_statement.inc
--source include/have_normal_bzip.inc
--source include/have_normal_zlib.inc
#
#
# mysqlbinlog: compressed query event
Expand Down
2 changes: 1 addition & 1 deletion mysql-test/suite/compat/oracle/t/column_compression.test
@@ -1,6 +1,6 @@
--source include/have_innodb.inc
--source include/have_csv.inc
--source include/have_normal_bzip.inc
--source include/have_normal_zlib.inc

SET sql_mode=ORACLE;

Expand Down
@@ -1,7 +1,7 @@
--source include/have_innodb.inc
--source include/have_sequence.inc
--source include/innodb_page_size_small.inc
--source include/have_normal_bzip.inc
--source include/have_normal_zlib.inc

call mtr.add_suppression("InnoDB: Cannot add field .* in table .* because after adding it, the row size is .* which is greater than maximum allowed size (.*) for a record on index leaf page.");

Expand Down

0 comments on commit 5b0a415

Please sign in to comment.