Skip to content

Commit

Permalink
update C/C, fix srpm build failures on fedora
Browse files Browse the repository at this point in the history
krb5-config (used by FindGSSAPI) returns `-lkrb5 -lk5crypto -lcom_err`
but only libkrb5 is actually used by the gssapi plugin. The other two
result in unneeded dependencies unless they're tagged optional when
linked with --as-needed.

Some distributions use --as-needed automatically, which causes our
builds to differ from srpm builds, introducing failures in buildbot.

Let's always use --as-needed for gssapi plugin
  • Loading branch information
vuvova committed Sep 26, 2022
1 parent 3dd03a2 commit 70701ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libmariadb
1 change: 1 addition & 0 deletions plugin/auth_gssapi/CMakeLists.txt
Expand Up @@ -38,6 +38,7 @@ ELSE()
IF(HAVE_KRB5_XFREE)
ADD_DEFINITIONS(-DHAVE_KRB5_XFREE=1)
ENDIF()
MY_CHECK_AND_SET_COMPILER_FLAG(-Wl,--as-needed)

ELSE()
# Can't build plugin
Expand Down

0 comments on commit 70701ee

Please sign in to comment.