Skip to content

Commit

Permalink
MDEV-26205 Merge new release of InnoDB 5.7.35 to 10.2
Browse files Browse the repository at this point in the history
  • Loading branch information
dr-m committed Jul 22, 2021
2 parents efae374 + 236f825 commit 742b3a0
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 23 deletions.
21 changes: 9 additions & 12 deletions storage/innobase/buf/buf0buf.cc
@@ -1,6 +1,6 @@
/*****************************************************************************
Copyright (c) 1995, 2018, Oracle and/or its affiliates. All Rights Reserved.
Copyright (c) 1995, 2021, Oracle and/or its affiliates.
Copyright (c) 2008, Google Inc.
Copyright (c) 2013, 2021, MariaDB Corporation.
Expand Down Expand Up @@ -1896,8 +1896,6 @@ buf_pool_init_instance(
LATCH_ID_HASH_TABLE_RW_LOCK,
srv_n_page_hash_locks, MEM_HEAP_FOR_PAGE_HASH);

buf_pool->page_hash_old = NULL;

buf_pool->zip_hash = hash_create(2 * buf_pool->curr_size);

buf_pool->last_printout_time = time(NULL);
Expand Down Expand Up @@ -2556,8 +2554,6 @@ buf_pool_resize_hash(
{
hash_table_t* new_hash_table;

ut_ad(buf_pool->page_hash_old == NULL);

/* recreate page_hash */
new_hash_table = ib_recreate(
buf_pool->page_hash, 2 * buf_pool->curr_size);
Expand Down Expand Up @@ -2589,8 +2585,14 @@ buf_pool_resize_hash(
}
}

buf_pool->page_hash_old = buf_pool->page_hash;
buf_pool->page_hash = new_hash_table;
/* Concurrent threads may be accessing
buf_pool->page_hash->n_cells, n_sync_obj and try to latch
sync_obj[i] while we are resizing. Therefore we never
deallocate page_hash, instead we overwrite n_cells (and other
fields) with the new values. The n_sync_obj and sync_obj are
actually same in both. */
std::swap(*buf_pool->page_hash, *new_hash_table);
hash_table_free(new_hash_table);

/* recreate zip_hash */
new_hash_table = hash_create(2 * buf_pool->curr_size);
Expand Down Expand Up @@ -3031,11 +3033,6 @@ buf_pool_resize()

hash_unlock_x_all(buf_pool->page_hash);
buf_pool_mutex_exit(buf_pool);

if (buf_pool->page_hash_old != NULL) {
hash_table_free(buf_pool->page_hash_old);
buf_pool->page_hash_old = NULL;
}
}

UT_DELETE(chunk_map_old);
Expand Down
14 changes: 8 additions & 6 deletions storage/innobase/fts/fts0fts.cc
@@ -1,7 +1,7 @@
/*****************************************************************************
Copyright (c) 2011, 2018, Oracle and/or its affiliates. All Rights Reserved.
Copyright (c) 2016, 2020, MariaDB Corporation.
Copyright (c) 2011, 2021, Oracle and/or its affiliates.
Copyright (c) 2016, 2021, MariaDB Corporation.
This program is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free Software
Expand Down Expand Up @@ -1299,6 +1299,9 @@ fts_cache_node_add_positions(
ptr = ilist + node->ilist_size;

node->ilist_size_alloc = new_size;
if (cache) {
cache->total_size += new_size;
}
}

ptr_start = ptr;
Expand All @@ -1325,17 +1328,16 @@ fts_cache_node_add_positions(
if (node->ilist_size > 0) {
memcpy(ilist, node->ilist, node->ilist_size);
ut_free(node->ilist);
if (cache) {
cache->total_size -= node->ilist_size;
}
}

node->ilist = ilist;
}

node->ilist_size += enc_len;

if (cache) {
cache->total_size += enc_len;
}

if (node->first_doc_id == FTS_NULL_DOC_ID) {
node->first_doc_id = doc_id;
}
Expand Down
6 changes: 2 additions & 4 deletions storage/innobase/include/buf0buf.h
@@ -1,7 +1,7 @@
/*****************************************************************************
Copyright (c) 1995, 2016, Oracle and/or its affiliates. All Rights Reserved.
Copyright (c) 2013, 2020, MariaDB Corporation.
Copyright (c) 1995, 2021, Oracle and/or its affiliates.
Copyright (c) 2013, 2021, MariaDB Corporation.
This program is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free Software
Expand Down Expand Up @@ -2037,8 +2037,6 @@ struct buf_pool_t{
page_hash mutex. Lookups can happen
while holding the buf_pool->mutex or
the relevant page_hash mutex. */
hash_table_t* page_hash_old; /*!< old pointer to page_hash to be
freed after resizing buffer pool */
hash_table_t* zip_hash; /*!< hash table of buf_block_t blocks
whose frames are allocated to the
zip buddy system,
Expand Down
2 changes: 1 addition & 1 deletion storage/innobase/include/univ.i
Expand Up @@ -41,7 +41,7 @@ Created 1/20/1994 Heikki Tuuri

#define INNODB_VERSION_MAJOR 5
#define INNODB_VERSION_MINOR 7
#define INNODB_VERSION_BUGFIX 34
#define INNODB_VERSION_BUGFIX 35

/* The following is the InnoDB version as shown in
SELECT plugin_version FROM information_schema.plugins;
Expand Down

0 comments on commit 742b3a0

Please sign in to comment.