Skip to content

Commit

Permalink
cleanup: don't update_virtual_fields from READ_RECORD
Browse files Browse the repository at this point in the history
it was done only in some access methods, not in all,
so the caller had to update_virtual_fields anyway.
  • Loading branch information
vuvova committed Dec 12, 2016
1 parent 163478d commit 7459f0c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions mysql-test/suite/vcol/r/vcol_supported_sql_funcs.result
Original file line number Diff line number Diff line change
Expand Up @@ -2619,7 +2619,6 @@ a b
-1 18446744073709551615
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1105 Cast to unsigned converted negative integer to it's positive complement
drop table t1;
set sql_warnings = 0;
# Convert()
Expand All @@ -2641,7 +2640,6 @@ a b
-1 18446744073709551615
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1105 Cast to unsigned converted negative integer to it's positive complement
drop table t1;
set sql_warnings = 0;
#
Expand Down
4 changes: 0 additions & 4 deletions sql/records.cc
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ static int rr_quick(READ_RECORD *info)
break;
}
}
if (info->table->vfield)
update_virtual_fields(info->thd, info->table);
return tmp;
}

Expand Down Expand Up @@ -483,8 +481,6 @@ int rr_sequential(READ_RECORD *info)
break;
}
}
if (!tmp && info->table->vfield)
update_virtual_fields(info->thd, info->table);
return tmp;
}

Expand Down

0 comments on commit 7459f0c

Please sign in to comment.