Skip to content

Commit

Permalink
Fix MYSQL_MAINTAINER_MODE=ERR, on Windows, with Ninja , in 10.2
Browse files Browse the repository at this point in the history
A conversion warning 4267 that we want to disable(prior to 10.3),
was suppressed with  cmake VS generator for C++ and C, despite being set
only for CXX flags.

The fix is to disable the warning in C flags, too. In 10.2, this warning
is noisy, in 10.3 it is fixed.
  • Loading branch information
vaintroub committed Sep 11, 2021
1 parent ac064c2 commit 7e6b033
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cmake/os/Windows.cmake
Expand Up @@ -150,6 +150,7 @@ IF(MSVC)
IF(CMAKE_SIZEOF_VOID_P EQUAL 8)
# Temporarily disable size_t warnings, due to their amount
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4267")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4267")
ENDIF()
IF(MYSQL_MAINTAINER_MODE MATCHES "ERR")
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX")
Expand Down

0 comments on commit 7e6b033

Please sign in to comment.