MDEV-33913 TABLE_STATISTICS increments ROWS_CHANGED twice upon UPDATE…

… and does not count DELETE
MariaDB · May 27, 2024 · 86055e4 · 86055e4
1 parent 94033fc
commit 86055e4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/mysql-test/main/information_schema_stats.result b/mysql-test/main/information_schema_stats.result
@@ -39,6 +39,9 @@ id	first_name	last_name	address	phone	email
 select * from just_a_test force index(primary) where id=8;
 id	first_name	last_name	address	phone	email
 update just_a_test set first_name="unlucky" where id=5;
+select * from information_schema.table_statistics where table_schema='test' and table_name='just_a_test';
+TABLE_SCHEMA	TABLE_NAME	ROWS_READ	ROWS_CHANGED	ROWS_CHANGED_X_INDEXES	ROWS_INSERTED	ROWS_UPDATED	ROWS_DELETED	KEY_READ_HITS	KEY_READ_MISSES
+test	just_a_test	31	6	6	5	1	0	4	1
 delete from just_a_test where id=5;
 select * from information_schema.table_statistics where table_schema='test' and table_name='just_a_test';
 TABLE_SCHEMA	TABLE_NAME	ROWS_READ	ROWS_CHANGED	ROWS_CHANGED_X_INDEXES	ROWS_INSERTED	ROWS_UPDATED	ROWS_DELETED	KEY_READ_HITS	KEY_READ_MISSES

diff --git a/mysql-test/main/information_schema_stats.test b/mysql-test/main/information_schema_stats.test
@@ -27,6 +27,7 @@ select * from information_schema.index_statistics where table_schema='test' and
 select * from just_a_test force index(primary) where id between 1 and 2;
 select * from just_a_test force index(primary) where id=8;
 update just_a_test set first_name="unlucky" where id=5;
+select * from information_schema.table_statistics where table_schema='test' and table_name='just_a_test';
 delete from just_a_test where id=5;
 select * from information_schema.table_statistics where table_schema='test' and table_name='just_a_test';
 select * from information_schema.index_statistics where table_schema='test' and table_name='just_a_test';

diff --git a/plugin/userstat/table_stats.cc b/plugin/userstat/table_stats.cc
@@ -48,7 +48,7 @@ static int table_stats_fill(THD *thd, TABLE_LIST *tables, COND *cond)
       continue;
 
     rows_changed= (rows_stats->inserted + rows_stats->updated +
-                   rows_stats->updated);
+                   rows_stats->deleted);
     table->field[0]->store(table_stats->table, schema_length,
                            system_charset_info);
     table->field[1]->store(table_stats->table + schema_length+1,