Minor cleanup

ReadView::ReadView(): Define inline, and remove the memset(). ReadView::~ReadView(): Use the default destructor.
MariaDB · Jan 24, 2018 · 9aa461b · 9aa461b
1 parent 4575ae7
commit 9aa461b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 24 deletions.
diff --git a/storage/innobase/include/read0types.h b/storage/innobase/include/read0types.h
@@ -1,6 +1,7 @@
 /*****************************************************************************
 
 Copyright (c) 1997, 2016, Oracle and/or its affiliates. All Rights Reserved.
+Copyright (c) 2018, MariaDB Corporation.
 
 This program is free software; you can redistribute it and/or modify it under
 the terms of the GNU General Public License as published by the Free Software
@@ -145,8 +146,7 @@ class ReadView {
 		friend class ReadView;
 	};
 public:
-	ReadView();
-	~ReadView();
+	ReadView() : m_ids(), m_open(false), m_registered(false) {}
 	/** Check whether transaction id is valid.
 	@param[in]	id		transaction id to check
 	@param[in]	name		table name */

diff --git a/storage/innobase/read/read0read.cc b/storage/innobase/read/read0read.cc
@@ -1,6 +1,7 @@
 /*****************************************************************************
 
 Copyright (c) 1996, 2015, Oracle and/or its affiliates. All Rights Reserved.
+Copyright (c) 2018, MariaDB Corporation.
 
 This program is free software; you can redistribute it and/or modify it under
 the terms of the GNU General Public License as published by the Free Software
@@ -318,28 +319,6 @@ ReadView::ids_t::insert(value_type value)
 	}
 }
 
-/**
-ReadView constructor */
-ReadView::ReadView()
-	:
-	m_low_limit_id(),
-	m_up_limit_id(),
-	m_creator_trx_id(),
-	m_ids(),
-	m_low_limit_no(),
-	m_open(false),
-	m_registered(false)
-{
-	ut_d(::memset(&m_view_list, 0x0, sizeof(m_view_list)));
-}
-
-/**
-ReadView destructor */
-ReadView::~ReadView()
-{
-	// Do nothing
-}
-
 /**
 Copy the transaction ids from the source vector */