Skip to content

Commit

Permalink
Remove btr_search_n_succ and btr_search_n_hash_fail counters
Browse files Browse the repository at this point in the history
  • Loading branch information
grooverdan committed Jun 2, 2016
1 parent 54332b2 commit a0b11b9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 40 deletions.
14 changes: 0 additions & 14 deletions storage/innobase/btr/btr0sea.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,6 @@ UNIV_INTERN char btr_search_enabled = TRUE;
/** A dummy variable to fool the compiler */
UNIV_INTERN ulint btr_search_this_is_zero = 0;

#ifdef UNIV_SEARCH_PERF_STAT
/** Number of successful adaptive hash index lookups */
UNIV_INTERN ulint btr_search_n_succ = 0;
/** Number of failed adaptive hash index lookups */
UNIV_INTERN ulint btr_search_n_hash_fail = 0;
#endif /* UNIV_SEARCH_PERF_STAT */

/** padding to prevent other memory update
hotspots from residing on the same memory
cache line as btr_search_latch */
Expand Down Expand Up @@ -651,10 +644,6 @@ btr_search_info_update_slow(
if (cursor->flag == BTR_CUR_HASH_FAIL) {
/* Update the hash node reference, if appropriate */

#ifdef UNIV_SEARCH_PERF_STAT
btr_search_n_hash_fail++;
#endif /* UNIV_SEARCH_PERF_STAT */

rw_lock_x_lock(&btr_search_latch);

btr_search_update_hash_ref(info, block, cursor);
Expand Down Expand Up @@ -1010,9 +999,6 @@ btr_search_guess_on_hash(
#endif
info->last_hash_succ = TRUE;

#ifdef UNIV_SEARCH_PERF_STAT
btr_search_n_succ++;
#endif
if (UNIV_LIKELY(!has_search_latch)
&& buf_page_peek_if_too_old(&block->page)) {

Expand Down
7 changes: 0 additions & 7 deletions storage/innobase/include/btr0sea.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,13 +256,6 @@ struct btr_search_sys_t{
/** The adaptive hash index */
extern btr_search_sys_t* btr_search_sys;

#ifdef UNIV_SEARCH_PERF_STAT
/** Number of successful adaptive hash index lookups */
extern ulint btr_search_n_succ;
/** Number of failed adaptive hash index lookups */
extern ulint btr_search_n_hash_fail;
#endif /* UNIV_SEARCH_PERF_STAT */

/** After change in n_fields or n_bytes in info, this many rounds are waited
before starting the hash analysis again: this is to save CPU time when there
is no hope in building a hash index. */
Expand Down
12 changes: 0 additions & 12 deletions storage/xtradb/btr/btr0sea.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@ UNIV_INTERN ulint btr_search_index_num;
/** A dummy variable to fool the compiler */
UNIV_INTERN ulint btr_search_this_is_zero = 0;

#ifdef UNIV_SEARCH_PERF_STAT
/** Number of successful adaptive hash index lookups */
UNIV_INTERN ulint btr_search_n_succ = 0;
/** Number of failed adaptive hash index lookups */
UNIV_INTERN ulint btr_search_n_hash_fail = 0;
#endif /* UNIV_SEARCH_PERF_STAT */

/** padding to prevent other memory update
hotspots from residing on the same memory
cache line as btr_search_latch */
Expand Down Expand Up @@ -698,10 +691,6 @@ btr_search_info_update_slow(
if (cursor->flag == BTR_CUR_HASH_FAIL) {
/* Update the hash node reference, if appropriate */

#ifdef UNIV_SEARCH_PERF_STAT
btr_search_n_hash_fail++;
#endif /* UNIV_SEARCH_PERF_STAT */

rw_lock_x_lock(btr_search_get_latch(cursor->index));

btr_search_update_hash_ref(info, block, cursor);
Expand Down Expand Up @@ -1059,7 +1048,6 @@ btr_search_guess_on_hash(
info->last_hash_succ = TRUE;

#ifdef UNIV_SEARCH_PERF_STAT
btr_search_n_succ++;
#endif
if (UNIV_LIKELY(!has_search_latch)
&& buf_page_peek_if_too_old(&block->page)) {
Expand Down
7 changes: 0 additions & 7 deletions storage/xtradb/include/btr0sea.h
Original file line number Diff line number Diff line change
Expand Up @@ -332,13 +332,6 @@ struct btr_search_sys_t{
/** The adaptive hash index */
extern btr_search_sys_t* btr_search_sys;

#ifdef UNIV_SEARCH_PERF_STAT
/** Number of successful adaptive hash index lookups */
extern ulint btr_search_n_succ;
/** Number of failed adaptive hash index lookups */
extern ulint btr_search_n_hash_fail;
#endif /* UNIV_SEARCH_PERF_STAT */

/** After change in n_fields or n_bytes in info, this many rounds are waited
before starting the hash analysis again: this is to save CPU time when there
is no hope in building a hash index. */
Expand Down

0 comments on commit a0b11b9

Please sign in to comment.