Skip to content

Commit

Permalink
Disable ps-protocol second execution on test that do not support it
Browse files Browse the repository at this point in the history
MDEV-31003 has introduced second execution for SELECTs that execute
under ps-protocol. The following tests in galera suites do not support
this mode of execution, disable it:

  galera.MDEV-27862
  galera.galera_log_output_csv
  galera.galera_query_cache
  galera.galera_query_cache_sync_wait
  galera_3nodes_sr.GCF-336
  galera_3nodes_sr.galera_sr_isolate_master
  galera_sr.galera_sr_large_fragment
  galera_sr.galera_sr_many_fragments

Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
  • Loading branch information
sciascid authored and sysprg committed Dec 22, 2023
1 parent 00a8151 commit c554f26
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mysql-test/suite/galera/t/MDEV-27862.test
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
--source include/galera_cluster.inc
--source include/have_innodb.inc

--disable_ps2_protocol

# NEXTVAL

--connection node_1
Expand Down Expand Up @@ -54,3 +56,4 @@ SELECT NEXTVAL(seq_transaction) = 4;
DROP SEQUENCE seq_transaction;
DROP TABLE t1;

--enable_ps2_protocol
4 changes: 4 additions & 0 deletions mysql-test/suite/galera/t/galera_log_output_csv.test
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ INSERT INTO t1 VALUES (1);

SELECT COUNT(*) > 0 FROM mysql.general_log;

--disable_ps2_protocol
SELECT 1 = 1 FROM t1;
SELECT COUNT(*) = 1 FROM mysql.slow_log WHERE sql_text = 'SELECT 1 = 1 FROM t1';
--enable_ps2_protocol

--connection node_2

--disable_ps2_protocol
SELECT 2 = 2 FROM t1;
SELECT COUNT(*) = 1 FROM mysql.slow_log WHERE sql_text = 'SELECT 2 = 2 FROM t1';
--enable_ps2_protocol

--connection node_1
DROP TABLE t1;
Expand Down
3 changes: 3 additions & 0 deletions mysql-test/suite/galera/t/galera_query_cache.test
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
--source include/galera_cluster.inc
--source include/have_innodb.inc

--disable_ps2_protocol

#
# Ensure that the query cache behaves properly with respect to Galera
#
Expand Down Expand Up @@ -65,3 +67,4 @@ SELECT VARIABLE_VALUE = 1 FROM INFORMATION_SCHEMA.SESSION_STATUS WHERE VARIABLE_

DROP TABLE t1;

--enable_ps2_protocol
4 changes: 4 additions & 0 deletions mysql-test/suite/galera/t/galera_query_cache_sync_wait.test
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
--source include/have_query_cache.inc
--source include/galera_have_debug_sync.inc

--disable_ps2_protocol

CREATE TABLE t1 (id INT PRIMARY KEY AUTO_INCREMENT) ENGINE=InnoDB;
INSERT INTO t1 VALUES (1);

Expand Down Expand Up @@ -88,3 +90,5 @@ DROP TABLE t1;

--connection node_2a
SET DEBUG_SYNC = "RESET";

--enable_ps2_protocol
5 changes: 5 additions & 0 deletions mysql-test/suite/galera_3nodes_sr/t/GCF-336.test
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--source include/galera_cluster.inc

--disable_ps2_protocol

--connection node_2
CREATE TABLE t1 (f1 INTEGER) ENGINE=InnoDB;

Expand Down Expand Up @@ -45,3 +47,6 @@ CALL mtr.add_suppression("WSREP: failed to send SR rollback for ");
--connect node_3, 127.0.0.1, root, , test, $NODE_MYPORT_3
--connection node_3
--source include/galera_wait_ready.inc


--enable_ps2_protocol
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
--source include/galera_cluster.inc
--source include/have_innodb.inc

--disable_ps2_protocol
#
# Test the effect of gmcast.isolate on master during an SR transaction
#
Expand Down Expand Up @@ -133,3 +134,4 @@ CALL mtr.add_suppression("failed to send SR rollback for");
DROP TABLE t1;

--source ../galera/include/auto_increment_offset_restore.inc
--enable_ps2_protocol
3 changes: 3 additions & 0 deletions mysql-test/suite/galera_sr/t/galera_sr_large_fragment.test
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
--source include/have_innodb.inc
--source include/big_test.inc

--disable_ps2_protocol

CREATE TABLE ten (f1 INTEGER) ENGINE=InnoDB;
INSERT INTO ten VALUES (1), (2), (3), (4), (5), (6), (7), (8), (9), (10);

Expand Down Expand Up @@ -56,3 +58,4 @@ CALL mtr.add_suppression('InnoDB: Resizing redo log from');
CALL mtr.add_suppression('InnoDB: Starting to delete and rewrite log files');
CALL mtr.add_suppression('InnoDB: New log files created, LSN=');

--enable_ps2_protocol
4 changes: 4 additions & 0 deletions mysql-test/suite/galera_sr/t/galera_sr_many_fragments.test
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
--source include/have_innodb.inc
--source include/big_test.inc

--disable_ps2_protocol

CREATE TABLE ten (f1 INTEGER) ENGINE=InnoDB;
INSERT INTO ten VALUES (1), (2), (3), (4), (5), (6), (7), (8), (9), (10);

Expand Down Expand Up @@ -51,3 +53,5 @@ SELECT COUNT(*) = 0 FROM t1;

DROP TABLE ten;
DROP TABLE t1;

--enable_ps2_protocol

0 comments on commit c554f26

Please sign in to comment.