Skip to content

Commit

Permalink
fix main.sp test failures
Browse files Browse the repository at this point in the history
make the select from mysql.proc stable and independent from
previous operations on the table.

also, remove redundant drops.
  • Loading branch information
vuvova committed May 20, 2021
1 parent 1fff239 commit d67663a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
5 changes: 1 addition & 4 deletions mysql-test/main/sp.result
Original file line number Diff line number Diff line change
Expand Up @@ -6237,9 +6237,6 @@ NULL
set @@character_set_client=@save_character_set_client;
set @@character_set_results=@save_character_set_client;
DROP PROCEDURE p1;
drop procedure if exists proc_25411_a;
drop procedure if exists proc_25411_b;
drop procedure if exists proc_25411_c;
create procedure proc_25411_a()
begin
/* real comment */
Expand Down Expand Up @@ -6300,7 +6297,7 @@ proc_25411_b CREATE DEFINER=`root`@`localhost` PROCEDURE `proc_25411_b`(
begin
select p1, p2;
end latin1 latin1_swedish_ci latin1_swedish_ci
select name, param_list, body from mysql.proc where name like "%25411%";
select name, param_list, body from mysql.proc where name like "%25411%" order by name;
name param_list body
proc_25411_a begin
/* real comment */
Expand Down
8 changes: 1 addition & 7 deletions mysql-test/main/sp.test
Original file line number Diff line number Diff line change
Expand Up @@ -7366,12 +7366,6 @@ DROP PROCEDURE p1;
# Bug#25411 (trigger code truncated)
#

--disable_warnings
drop procedure if exists proc_25411_a;
drop procedure if exists proc_25411_b;
drop procedure if exists proc_25411_c;
--enable_warnings

delimiter $$;

create procedure proc_25411_a()
Expand Down Expand Up @@ -7412,7 +7406,7 @@ show create procedure proc_25411_a;
call proc_25411_a();

show create procedure proc_25411_b;
select name, param_list, body from mysql.proc where name like "%25411%";
select name, param_list, body from mysql.proc where name like "%25411%" order by name;
call proc_25411_b(10, 20);

show create procedure proc_25411_c;
Expand Down

0 comments on commit d67663a

Please sign in to comment.