Skip to content

Commit

Permalink
Fixed that test suite doesn't remove duplicate options
Browse files Browse the repository at this point in the history
- multiple usage of plugin-load-add and optimizer-switch are now included
  in generated config files
  • Loading branch information
montywi committed Jun 6, 2019
1 parent bb5d04c commit d6d5c16
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion mysql-test/lib/My/Config.pm
Expand Up @@ -21,6 +21,17 @@ use strict;
use warnings;
use Carp;

# Define all MariaDB options that the user should be able to specify
# many times in the config file. Note that options must be written
# using '-' instead of '_' here!

my %multipart_options=
(
"plugin-load-add" => 1,
"optimizer-switch" => 1,
);


sub new {
my ($class, $option_name, $option_value)= @_;
my $self= bless { name => $option_name,
Expand Down Expand Up @@ -327,7 +338,6 @@ sub new {
# Skip comment
next;
}

else {
croak "Unexpected line '$line' found in '$path'";
}
Expand Down Expand Up @@ -355,6 +365,11 @@ sub insert {

if ( defined $option ) {
#print "option: $option, value: $value\n";
my $tmp_option= $option;
$tmp_option =~ s/_/-/g;

# If the option is an option that one can specify many times, always add
$if_not_exist= 1 if (@multipart_options{$tmp_option});

# Add the option to the group
$group->insert($option, $value, $if_not_exist);
Expand Down

0 comments on commit d6d5c16

Please sign in to comment.