Skip to content

Commit

Permalink
Deb: Stop using mariadb-service-convert
Browse files Browse the repository at this point in the history
We can't expect that users want to always convert their mysqld_safe
settings on an upgrade. In its current form it will always run, and that
seems unnecessary on every single installation.

Also the script is buggy, leaks mysqld_safe output into the written file
and since it gets syntax errors the whole mariadb.service will fail to
work.
  • Loading branch information
ottok committed May 16, 2020
1 parent 69964c4 commit dab5698
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions debian/mariadb-server-10.5.postinst
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,6 @@ EOF
fi
fi

# copy out any mysqld_safe settings
systemd_conf=/etc/systemd/system/mariadb.service.d/migrated-from-my.cnf-settings.conf
if [ -x /usr/bin/mariadb-service-convert -a ! -f "${systemd_conf}" ]; then
mkdir -p /etc/systemd/system/mariadb.service.d
/usr/bin/mariadb-service-convert > "${systemd_conf}"
fi
;;

abort-upgrade|abort-remove|abort-configure)
Expand Down

0 comments on commit dab5698

Please sign in to comment.