Skip to content

Commit

Permalink
Don't print "Trying to delete tablespace several 10x times per second"
Browse files Browse the repository at this point in the history
Now this InnoDB message is printed after one second of stalled operations
and then every 10 seconds
  • Loading branch information
montywi committed May 23, 2020
1 parent 4ea171f commit dcc0baf
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions storage/innobase/fil/fil0fil.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2024,7 +2024,8 @@ static ulint fil_check_pending_ops(const fil_space_t* space, ulint count)

if (ulint n_pending_ops = space->n_pending_ops) {

if (count > 5000) {
/* Give a warning every 10 second, starting after 1 second */
if ((count % 500) == 50) {
ib::warn() << "Trying to delete"
" tablespace '" << space->name
<< "' but there are " << n_pending_ops
Expand Down Expand Up @@ -2071,7 +2072,8 @@ fil_check_pending_io(

ut_a(!(*node)->being_extended);

if (count > 1000) {
/* Give a warning every 10 second, starting after 1 second */
if ((count % 500) == 50) {
ib::warn() << "Trying to delete"
" tablespace '" << space->name
<< "' but there are "
Expand Down Expand Up @@ -2130,7 +2132,7 @@ fil_check_pending_operations(
mutex_exit(&fil_system.mutex);

if (count > 0) {
os_thread_sleep(20000);
os_thread_sleep(20000); // Wait 0.02 seconds
}

mutex_enter(&fil_system.mutex);
Expand Down Expand Up @@ -2160,7 +2162,7 @@ fil_check_pending_operations(
break;
}

os_thread_sleep(20000);
os_thread_sleep(20000); // Wait 0.02 seconds
mutex_enter(&fil_system.mutex);
}

Expand Down

0 comments on commit dcc0baf

Please sign in to comment.