Skip to content

Commit

Permalink
Reverted wrong patch for mysql_upgrade
Browse files Browse the repository at this point in the history
The original code was correct. mysql_upgrade calls the mysql client to
talk with MariaDB. It doesn't call itself!
  • Loading branch information
montywi authored and grooverdan committed Sep 25, 2020
1 parent 1be8ac3 commit e0f5e7b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion client/mysql_upgrade.c
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,7 @@ static int check_version_match(void)
extract_variable_from_show(&ds_version, version_str))
{
print_error("Version check failed. Got the following error when calling "
"the 'mysql_upgrade' command line client", &ds_version);
"the 'mysql' command line client", &ds_version);
dynstr_free(&ds_version);
return 1; /* Query failed */
}
Expand Down
4 changes: 2 additions & 2 deletions mysql-test/r/mysql_upgrade.result
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ test
Phase 7/7: Running 'FLUSH PRIVILEGES'
OK
DROP USER mysqltest1@'%';
Version check failed. Got the following error when calling the 'mysql_upgrade' command line client
Version check failed. Got the following error when calling the 'mysql' command line client
ERROR 1045 (28000): Access denied for user 'mysqltest1'@'localhost' (using password: YES)
FATAL ERROR: Upgrade failed
Run mysql_upgrade with a non existing server socket
Expand Down Expand Up @@ -405,7 +405,7 @@ OK
# Bug #21489398: MYSQL_UPGRADE: FATAL ERROR: UPGRADE FAILED - IMPROVE ERROR
#
Run mysql_upgrade with unauthorized access
Version check failed. Got the following error when calling the 'mysql_upgrade' command line client
Version check failed. Got the following error when calling the 'mysql' command line client
ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: YES)
FATAL ERROR: Upgrade failed
#
Expand Down

0 comments on commit e0f5e7b

Please sign in to comment.