ApplicationContext.ServiceProviderScope in Csla 5.4.0

[ajohnstone-ks]

It looks like the type of ApplicationContext.ServiceProviderScope was changed from IServiceScope to IServiceProvider. That seems like a mistake. If not, it doesn't seem there's anyway now to set a scope to use.

[rockfordlhotka]

Yes, that does seem like a mistake. I think (not sure) that came with the service provider changes from @dazinator - any insight on this?

[dazinator]

No it was intentional,
When you create a service scope, the IServiceScope has an IServiceProvider exposed as a property - that's the thing that CSLA needs. You can hand CSLA your root application IServiceProvider, or you can create scopes and hand CSLA your scopes IServiceProvider, csla doesn't care, it will use the IServiceProvider provided to do its DI.

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.dependencyinjection.iservicescope?view=dotnet-plat-ext-5.0

[ajohnstone-ks]

Ok, can I suggest that property get renamed to something else then? Its a bit confusing because there is a scope concept as well.

[rockfordlhotka]

Would you create an issue for this please?

[ajohnstone-ks]

Oops, when I got the email with your response I thought it was about the other discussion.

This is capture here: #1999