Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UpdateAllChildren to FieldManager #1172

Merged
merged 2 commits into from
May 31, 2019
Merged

Added UpdateAllChildren to FieldManager #1172

merged 2 commits into from
May 31, 2019

Conversation

j055
Copy link
Contributor

@j055 j055 commented May 31, 2019

#1167

Added 2 unit tests

Note:
FieldDataManager.UpdateAllChildren uses ChildDataPortal directly, whereas UpdateChildren uses DataPortal class.

@rockfordlhotka
Copy link
Member

In this case I think I'm ok with not calling the DataPortal class. If we need to make that happen in the future it wouldn't be hard to do, but right now there's not a pressing need (that I can see) for expanding that part of the overall API.

@rockfordlhotka rockfordlhotka merged commit 6e3dc99 into MarimerLLC:master May 31, 2019
@j055 j055 deleted the feature/update-all-children branch May 31, 2019 17:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants