Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent use of .. or : in file path #3552

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

rockfordlhotka
Copy link
Member

Closes #3551

@rockfordlhotka
Copy link
Member Author

@BaHXeLiSiHg fyi, I'm requesting your review here because the code being affected exists due to a PR we worked on quite some time ago, to enable loading/unloading assemblies in memory. The result is a potential security issue that's been uncovered, and this is an attempt to resolve that by preventing loading assemblies from outside the app's bin directory tree.

Copy link
Contributor

@BaHXeLiSiHg BaHXeLiSiHg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm okay with that.

@rockfordlhotka rockfordlhotka merged commit 2c32a57 into MarimerLLC:main Nov 16, 2023
1 check passed
@rockfordlhotka rockfordlhotka deleted the 3551-assemblyload branch November 16, 2023 18:19
@sampizzey
Copy link

Hi folks,
Do you know if this issue was ever assigned a CVE identifier, and if not, could one be assigned (probably most easily using Githubs system for it, as the project has the module enabled already?)

@rockfordlhotka
Copy link
Member Author

I've never explored that concept @sampizzey, would this be in GH or NuGet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent the use of ../ when loading assemblies
3 participants