Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET 7 context behavior #3667

Merged
merged 1 commit into from Jan 31, 2024

Conversation

rockfordlhotka
Copy link
Member

Closes #3657

@rockfordlhotka rockfordlhotka merged commit 7a309db into MarimerLLC:main Jan 31, 2024
1 check passed
@swegele
Copy link
Contributor

swegele commented Jan 31, 2024

@rockfordlhotka I'm a little confused as to what the new ApplicationContextManagerInMemory is there for (maybe the comments are confusing because it references using HttpContextAccessor but it doesn't actually use that unless I'm missing something).

If a circuit exists then we shouldn't be using HttpContextAccessor because that is not reliable as per MS guidance?

@rockfordlhotka
Copy link
Member Author

Yeah, the comments need updating for sure!

The in-memory type I just added is actually the old context manager from Blazor 6 and 7 (the comments were wrong then too). I just re-added it with a new type name because the new context manager for Blazor 8 doesn't work with older versions of Blazor.

So this is really a temporary thing, until Blazor 6 and 7 go out of support, and then this can be removed (again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Blazor 7 state management
2 participants