-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide images for documentation about Roslyn Analyzers #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant2002
commented
Jun 25, 2024
55745ce
to
5ab7d76
Compare
Also - Add fix for the code fix broken when static constructor is present in the class. - Add debugging setup for the Csla.Analyzers project Closes MarimerLLC#1519 Closes MarimerLLC#4061
5ab7d76
to
b494c5b
Compare
rockfordlhotka
requested changes
Jun 26, 2024
docs/Analyzers.md
Outdated
|
||
![Crash of the analyzer](images/AnalyzerCrash.png "Crash of the analyzer") | ||
|
||
Unfortunately, Visual Studio doesn't make it easy to get crash information on an analyzer. If you want provide more information in addition to stack trace, or something is more complicated, you can launch `devenv.exe` with the `/log` switch, and see if the log file contains any meaningful information. Also, please log an issue on the CSLA site if you do find problems with an analyzer, and we'll do our best to resolve the problem. | ||
|
||
## Analyzer Proposals | ||
|
||
If you have an idea for an analyzer that would be beneficial for developers using CSLA, please propose it in the forums (https://github.com/MarimerLLC/cslaforum/issues). Tag it with "feature discussion". If it's decided that it's a good idea to implement, it'll be moved to the CSLA issues list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current/correct url is https://github.com/MarimerLLC/csla/discussions
@@ -86,10 +86,11 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context) | |||
{ | |||
var classSymbol = model.GetDeclaredSymbol(classNode); | |||
|
|||
//System.Diagnostics.Debugger.Launch(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code
rockfordlhotka
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
Closes #1519
Closes #4061