Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RabbitMq data portal channel #4068

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Fix RabbitMq data portal channel #4068

merged 16 commits into from
Jul 1, 2024

Conversation

rockfordlhotka
Copy link
Member

Closes #3928

StefanOssendorf
StefanOssendorf requested changes Jun 27, 2024
View reviewed changes
Source/Csla.Channels.RabbitMq/ProxyListener.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/ProxyListener.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqChannelExtensions.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqPortal.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqPortalOptions.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqPortalOptions.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqProxy.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqProxyOptions.cs Outdated Show resolved Hide resolved
StefanOssendorf
StefanOssendorf requested changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@StefanOssendorf StefanOssendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the nullable comment "blocks" this PR. The other two are just remarks/opinions but not necessary (even though I think they would be worth it)

Source/Csla.Channels.RabbitMq/RabbitMqPortal.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqPortal.cs Outdated Show resolved Hide resolved
Source/Csla.Channels.RabbitMq/RabbitMqPortalFactory.cs Outdated Show resolved Hide resolved
StefanOssendorf
StefanOssendorf approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@StefanOssendorf StefanOssendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rockfordlhotka rockfordlhotka merged commit d8c7df2 into main Jul 1, 2024
1 check passed
@rockfordlhotka rockfordlhotka deleted the dev/3928-rabbitmq branch July 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanOssendorf StefanOssendorf StefanOssendorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RabbitMqPortal needs to be revisited because it's not functional in the current state
2 participants
@rockfordlhotka @StefanOssendorf