Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastMNN compute.variances #31

Closed
johnmous opened this issue Feb 20, 2019 · 2 comments
Closed

fastMNN compute.variances #31

johnmous opened this issue Feb 20, 2019 · 2 comments

Comments

@johnmous
Copy link

johnmous commented Feb 20, 2019

In the fastMNN function description I read:

If compute.variances=TRUE, the function will compute the percentage of variance that is parallel to the average correction vectors at each merge step.

As I understand it, for n batches I should get n-1 percentages as there are n-1 merge steps. For example, for 2 batches there is a single merge step and I should get 1 percentage. What I get from the function though is n percentages, that is 2 percentages in the case of 2 batches.

Will you please explain this?

@LTLA
Copy link
Collaborator

LTLA commented Feb 20, 2019

It's the percentage of variance that is lost from each batch across all merge steps, so you'll get one value per batch. Admittedly, the documentation could be clearer about this. I guess I could also compute the percentage of variance lost at each batch at each merge step, but no one's needed that level of detail yet.

FYI, the MNN functions are to be moved to a new package that should be available in the next Bioconductor release, so the documentation updates will take place there.

@johnmous
Copy link
Author

Thanks a lot for the informative and quick reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants