Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (table): move <tbody> outside the loop #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jay8t6
Copy link
Contributor

@jay8t6 jay8t6 commented Jul 16, 2020

No description provided.

@ryuhhnn
Copy link
Contributor

ryuhhnn commented Jul 16, 2020

Running the update snapshots command should fix this build

FAILED TESTS:
 
  chameleon-table
 
    ✖ doesn't render pagination if .hidePagination is true
 
      HeadlessChrome 84.0.4147 (Linux 0.0.0)
 
    AssertionError: Received value does not match stored snapshot 0

@kewalter
Copy link
Contributor

I want to verify that this doesn't break the ability to hide/show detail rows. The tbody was used as a workaround, but I can't remember exactly why.

@chuckhousley chuckhousley removed their assignment Dec 3, 2020
@ZempTime ZempTime removed their assignment Feb 22, 2021
@terrencebowen terrencebowen removed their assignment Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants