Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop timers when socket is closed in destroy() #26

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Stop timers when socket is closed in destroy() #26

merged 1 commit into from
Mar 14, 2016

Conversation

waynelee
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 54.98%

Merging #26 into master will increase coverage by +0.32% as of 4e6dde4

@@            master     #26   diff @@
======================================
  Files           42      42       
  Stmts         1211    1213     +2
  Branches       181     181       
  Methods          0       0       
======================================
+ Hit            662     667     +5
+ Partial         24      21     -3
  Missed         525     525

Review entire Coverage Diff as of 4e6dde4

Powered by Codecov. Updated on successful CI builds.

MariusRumpf added a commit that referenced this pull request Mar 14, 2016
@MariusRumpf
Merge pull request #26 from waynelee/stoptimers
47627c4 
Stop timers when socket is closed in destroy()
@MariusRumpf MariusRumpf merged commit 47627c4 into MariusRumpf:master Mar 14, 2016
@MariusRumpf
Copy link
Owner

Good catch, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waynelee @codecov-io @MariusRumpf