Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge kiln #39

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Merge kiln #39

wants to merge 33 commits into from

Conversation

MariusVanDerWijden
Copy link
Owner

No description provided.

@lightclient
Copy link

What is the correct behavior if EL gets an fcu for the same block twice? I believe geth currently logs an error Impossible reorg, please file an issue.

@MariusVanDerWijden
Copy link
Owner Author

The fcu should be executed (which we do, thus generating the error)
The error is a relic of old days where calling reorg with the same head was weird behavior and indicated an issue.
It does not indicate an issue anymore so this log message should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants