Update octicon version (#1652)

MarkBind · Sep 18, 2021 · 306fb05 · 306fb05
1 parent efc101c
commit 306fb05
Show file tree

Hide file tree

Showing 9 changed files with 76 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/cli/test/functional/testUtil/compare.js b/packages/cli/test/functional/testUtil/compare.js
@@ -8,7 +8,7 @@ const diffChars = require('./diffChars');
 const _ = {};
 _.isEqual = require('lodash/isEqual');
 
-// Other files to ignore / files with binary extensions not recognised by istextorbinary package
+// Other files to ignore / files with binary extensions not recognized by istextorbinary package
 const TEST_BLACKLIST = ignore().add([
   '*.log',
   '*.woff',
@@ -24,6 +24,7 @@ function _readFileSync(...paths) {
   return fs.readFileSync(path.resolve(...paths), 'utf8');
 }
 
+//  Used to compare files expected to be generated by the build process against the expected files
 function compare(root, expectedSiteRelativePath = 'expected', siteRelativePath = '_site') {
   const expectedDirectory = path.join(root, expectedSiteRelativePath);
   const actualDirectory = path.join(root, siteRelativePath);
@@ -65,7 +66,9 @@ function compare(root, expectedSiteRelativePath = 'expected', siteRelativePath =
   }
   /* eslint-enable no-continue */
 
-  if (error) throw new Error('Diffs found in files');
+  if (error) {
+    throw new Error('Diffs found in files');
+  }
 }
 
 module.exports = {

diff --git a/packages/cli/test/functional/test_site/expected/markbind/css/octicons.css b/packages/cli/test/functional/test_site/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/packages/cli/test/functional/test_site_algolia_plugin/expected/markbind/css/octicons.css b/packages/cli/test/functional/test_site_algolia_plugin/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/packages/cli/test/functional/test_site_convert/expected/markbind/css/octicons.css b/packages/cli/test/functional/test_site_convert/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/packages/cli/test/functional/test_site_special_tags/expected/markbind/css/octicons.css b/packages/cli/test/functional/test_site_special_tags/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/...s/cli/test/functional/test_site_templates/test_default/expected/markbind/css/octicons.css b/...s/cli/test/functional/test_site_templates/test_default/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/...s/cli/test/functional/test_site_templates/test_minimal/expected/markbind/css/octicons.css b/...s/cli/test/functional/test_site_templates/test_minimal/expected/markbind/css/octicons.css
@@ -2,4 +2,5 @@
   display: inline-block;
   vertical-align: text-top;
   fill: currentColor;
+  overflow: visible;
 }
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -26,7 +26,7 @@
   "dependencies": {
     "@fortawesome/fontawesome-free": "^5.14.0",
     "@markbind/core-web": "^3.0.6",
-    "@primer/octicons": "^9.3.1",
+    "@primer/octicons": "^15.0.1",
     "@sindresorhus/slugify": "^0.9.1",
     "bluebird": "^3.7.2",
     "bootswatch": "^4.4.1",
@@ -71,4 +71,4 @@
     "jest": "^26.1.0",
     "memfs": "^3.0.1"
   }
-}
+}