Remove empty title tags in generated tests (#2186)

MarkBind · Mar 15, 2023 · 320a0f2 · 320a0f2
1 parent 33cd541
commit 320a0f2
Show file tree

Hide file tree

Showing 31 changed files with 6 additions and 56 deletions.
diff --git a/packages/cli/test/functional/test_site/expected/siteData.json b/packages/cli/test/functional/test_site/expected/siteData.json
@@ -81,21 +81,18 @@
     },
     {
       "src": "sub_site/index.md",
-      "title": "",
       "headings": {
         "feature-list": "Feature list"
       },
       "headingKeywords": {}
     },
     {
       "src": "sub_site/nested_sub_site/index.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "test_md_fragment.md",
-      "title": "",
       "headings": {
         "some-heading": "Some heading"
       },

diff --git a/packages/cli/test/functional/test_site/expected/sub_site/index.html b/packages/cli/test/functional/test_site/expected/sub_site/index.html
@@ -10,7 +10,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/test_site/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/test_site/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/test_site/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site/expected/sub_site/nested_sub_site/index.html b/packages/cli/test/functional/test_site/expected/sub_site/nested_sub_site/index.html
@@ -10,7 +10,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/test_site/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/test_site/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/test_site/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site/expected/test_md_fragment.html b/packages/cli/test/functional/test_site/expected/test_md_fragment.html
@@ -10,7 +10,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/test_site/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/test_site/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/test_site/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Home.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Home.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Page-1.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Page-1.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Footer.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Footer.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Sidebar.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Sidebar.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/about.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/about.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...es/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic1.html b/...es/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic1.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...es/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic2.html b/...es/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic2.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...s/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3a.html b/...s/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3a.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...s/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3b.html b/...s/cli/test/functional/test_site_convert/test_basic_convert/expected/contents/topic3b.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/index.html b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/index.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/siteData.json b/packages/cli/test/functional/test_site_convert/test_basic_convert/expected/siteData.json
@@ -9,67 +9,57 @@
     },
     {
       "src": "Home.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "Page-1.md",
-      "title": "",
       "headings": {
         "page-1": "Page 1"
       },
       "headingKeywords": {}
     },
     {
       "src": "_Footer.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "_Sidebar.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "about.md",
-      "title": "",
       "headings": {
         "about": "About"
       },
       "headingKeywords": {}
     },
     {
       "src": "contents/topic1.md",
-      "title": "",
       "headings": {
         "topic-1": "Topic 1"
       },
       "headingKeywords": {}
     },
     {
       "src": "contents/topic2.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "contents/topic3a.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "contents/topic3b.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "index.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     }

diff --git a/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Home.html b/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Home.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Page-1.html b/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/Page-1.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/README.html b/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/README.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/about.html b/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/about.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...i/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic1.html b/...i/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic1.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...i/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic2.html b/...i/test/functional/test_site_convert/test_navigation_convert/expected/contents/topic2.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/.../test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3a.html b/.../test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3a.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/.../test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3b.html b/.../test/functional/test_site_convert/test_navigation_convert/expected/contents/topic3b.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/index.html b/packages/cli/test/functional/test_site_convert/test_navigation_convert/expected/index.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...ages/cli/test/functional/test_site_convert/test_navigation_convert/expected/siteData.json b/...ages/cli/test/functional/test_site_convert/test_navigation_convert/expected/siteData.json
@@ -9,87 +9,75 @@
     },
     {
       "src": "Home.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "Page-1.md",
-      "title": "",
       "headings": {
         "page-1": "Page 1"
       },
       "headingKeywords": {}
     },
     {
       "src": "README.md",
-      "title": "",
       "headings": {
         "readme": "Readme"
       },
       "headingKeywords": {}
     },
     {
       "src": "about.md",
-      "title": "",
       "headings": {
         "about": "About"
       },
       "headingKeywords": {}
     },
     {
       "src": "contents/topic1.md",
-      "title": "",
       "headings": {
         "topic-1": "Topic 1"
       },
       "headingKeywords": {}
     },
     {
       "src": "contents/topic2.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "contents/topic3a.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "contents/topic3b.md",
-      "title": "",
       "headings": {},
       "headingKeywords": {}
     },
     {
       "src": "index.md",
-      "title": "",
       "headings": {
         "readme": "Readme"
       },
       "headingKeywords": {}
     },
     {
       "src": "test_folder/extra_1.md",
-      "title": "",
       "headings": {
         "sample-content-in-another-folder-which-is-not-named-content": "Sample content in another folder which is not named content"
       },
       "headingKeywords": {}
     },
     {
       "src": "test_folder/extra_2.md",
-      "title": "",
       "headings": {
         "sample-content-in-another-folder-which-is-not-named-content": "Sample content in another folder which is not named content"
       },
       "headingKeywords": {}
     },
     {
       "src": "test_folder/extra_3.md",
-      "title": "",
       "headings": {
         "sample-content-in-another-folder-which-is-not-named-content": "Sample content in another folder which is not named content"
       },

diff --git a/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_1.html b/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_1.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_2.html b/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_2.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_3.html b/...st/functional/test_site_convert/test_navigation_convert/expected/test_folder/extra_3.html
@@ -6,7 +6,6 @@
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="generator" content="MarkBind 4.1.0">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title></title>
   <link rel="stylesheet" href="/markbind/css/bootstrap.min.css">
   <link rel="stylesheet" href="/markbind/fontawesome/css/all.min.css">
   <link rel="stylesheet" href="/markbind/glyphicons/css/bootstrap-glyphicons.min.css">

diff --git a/packages/core/src/Page/PageConfig.ts b/packages/core/src/Page/PageConfig.ts
@@ -63,7 +63,7 @@ export class PageConfig {
    * The source file's (.md) posix relative file path for rendering this page
    */
   src: string;
-  title: string;
+  title?: string;
   template: Template;
   variableProcessor: VariableProcessor;
   addressablePagesSource: string[];
@@ -106,7 +106,7 @@ export class PageConfig {
     this.siteOutputPath = args.siteOutputPath;
     this.sourcePath = args.sourcePath;
     this.src = args.src;
-    this.title = args.title || '';
+    this.title = args.title;
     this.template = args.template;
     this.variableProcessor = args.variableProcessor;
     this.addressablePagesSource = args.addressablePagesSource;