-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate <import> and <variable> #1353
Comments
(1) and (4) have been merged in for (2), I noticed that the current requirement of allowing variables in json to also reference other variables makes the re-implementation considerably more complex, but not impossible I'm thinking that external variables should not be allowed to do so, since
Since its a new feature / replacement of an existing feature, we could do away with this (existing What do you think? @damithc |
I guess we can live without it. So, go ahead. 👍 |
MarkBind page variables requires processing html before nunjucks and markdown syntax. This poses several architectural issues (MarkBind#1353) of simplicity, performance, and extensibility of markdown syntax. As another step in removing this prerequisite, let's reimplement external json variables using a nunjucks extension.
MarkBind page variables requires processing html before nunjucks and markdown syntax. This poses several architectural issues (#1353) of simplicity, performance, and extensibility of markdown syntax. As another step in removing this prerequisite, let's reimplement external json variables using a nunjucks extension.
will be getting a new release out since that's all on the deprecation plate, I will be fast tracking the code to v3.0 from now on as well since full deprecation of this is necessary for the aims. It'll mostly be backend changes requiring / including deprecation of some
|
Page variables and imports require processing html before nunjucks and markdown. This poses several architectural issues of simplicity and performance outlined in #1353. Since these features now have viable alternatives, let's remove them.
Is your request related to a problem?
Opening an issue to track: #751 (comment)
Describe the solution you'd like
<include><variable>...</variable></include>
to override{% set / import %}
<import>
and<variable>
<import>
and<variable>
(v3.0)Additional context
See discussion here #751 (comment)
The text was updated successfully, but these errors were encountered: