Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all CI / CD to github actions #1386

Closed
damithc opened this issue Nov 11, 2020 · 4 comments · Fixed by #1759
Closed

Move all CI / CD to github actions #1386

damithc opened this issue Nov 11, 2020 · 4 comments · Fixed by #1759

Comments

@damithc
Copy link
Contributor

damithc commented Nov 11, 2020

There is a change to Travis pricing model https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
We should explore alternatives e.g., GitHub Actions

@ang-zeyu ang-zeyu added a-DevOps d.moderate p.High To be done in the next few releases labels Dec 12, 2020
@ang-zeyu ang-zeyu added p.Medium and removed p.High To be done in the next few releases labels Apr 10, 2021
@ang-zeyu ang-zeyu changed the title Explore moving out of Travis Move all CI / CD to github actions Jan 14, 2022
@ang-zeyu
Copy link
Contributor

Remaining:

  • appveyor
  • docs deployment (see travis.yml)

@ang-zeyu ang-zeyu added p.Low and removed p.Medium labels Jan 29, 2022
@tlylt
Copy link
Contributor

tlylt commented Feb 9, 2022

Remaining:

  • appveyor

Currently we run tests on every PR via Appveyor and Github Actions, do you mean we should remove the Appveyor check since Github Actions script now runs the test as well.
image

If that's the case, I guess the course of action:

  • remove appveyor.yml in root directory
  • terminate the CI on Appveyor platform
  • update ci.yml to run test on both Ubuntu, Windows & MacOS

@jonahtanjz
Copy link
Contributor

Currently we run tests on every PR via Appveyor and Github Actions, do you mean we should remove the Appveyor check since Github Actions script now runs the test as well.

@tlylt I believe they are running the same tests but the difference is that Appveyor is running the tests on a Windows environment and the current Github Actions is using an Ubuntu environment. Since Github Actions also supports Windows environment, we should also include the Windows environment tests on our Github Actions and remove the one on Appveyor.

@tlylt
Copy link
Contributor

tlylt commented Feb 9, 2022

Since Github Actions also supports Windows environment, we should also include the > > Windows environment tests on our Github Actions and remove the one on Appveyor.

Yup sure, I have updated the tasks in my above comment, I think in the same vein we should take this opportunity to cover macOS as well for running the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants