-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to test on all major OS and remove Appveyor #1757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tlylt!
LGTM 👍
Not sure if I have the rights to turn off Appveyor, might need one of the senior devs to help with this.
(Update: will indeed need someone with the access :)
Seems like I don't have the permission as well to uninstall the Appveyor app. Perhaps @ang-zeyu can take a look at this?
Hi guys, I just want to drop in about this merge. It seems that currently open PRs still runs the old CI workflow ( I might try closing and reopening a PR, to see whether the reopening would trigger the new workflow instead. |
Would merging the master back to the PR branch work? I am thinking because the PR branch may not be up to date that's why the CI is a bit weird... |
Update: closing and reopening PR works in triggering the new workflow. However, the required checks are still of the old workflows. Plus Let me see if I can modify the status checks for PRs to |
Okay, I have changed the required status checks to Also, I just noticed that we still have an active webhook to Appveyor on PRs and pushes. I deactivated it (but still exists) just to try out whether Appveyor would stop triggering builds and show up on the status check. (Update: recently merged PR does not trigger the build, yay?) @ang-zeyu @jonahtanjz is there anything else that we need to do to accommodate the new workflow? |
For the active webhook, are you referring to some repo settings or? I made the deletion of the Appveyor config file but I didn't notice any "webhook" or related settings in other files. |
What is the purpose of this pull request?
Overview of changes:
Related to: #1386
setup-node
to v2Anything you'd like to highlight / discuss:
Not sure if I have the rights to turn off Appveyor, might need one of the senior devs to help with this.
(Update: will indeed need someone with the access :)
Testing instructions:
nil
Proposed commit message: (wrap lines at 72 characters)
Improve CI script
Currently, we are using GitHub actions and Appveyor to
run tests for PRs.
Let's remove the use of Appveyor and consolidate CI tests
in GitHub actions. Let's also update the
setup-node
actionversion.
Checklist: ☑️