-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Google Fonts Icons #1505
Comments
I think it's possible. Maybe we can explore implementing it as a plugin? |
Support for other icon types are built-in. We can implement this as a plugin only if there is a good reason to differ from others. e.g., if adding this impose a significant performance cost, we can provide it as an optional feature (i.e., plugin) |
Just checking if this issue is still active. Thank you. |
@riyadh-h feel free to give it a try |
So, I tried using these icons, and they don't seem to be aligned with any surrounding text: I assumed that the font size used for the icons was larger compared to the text's, so I tried resizing them to 18px. Do you think we should proceed with the original size, or is there another way to go about this? |
Just curious... have you tried to align the icon via some CSS? (maybe some kind of vertical-align) |
@tlylt Not really, but now that you've mentioned it, I tried giving the icons a Cheers 😄 EDIT: I'll use Bootstrap's |
After some testing, I noticed that some icons aren't displayed on the rendered page when used. For example, assume the syntax used looks similar to this: # Google Material Icons
This is some text preceding the icon :google-work: and this succeeds it.
An:google-face:ther example.
:google-verified: The resulting page looks like this: As seen in the screenshot above, the verified icon, which looks like this: I believe the reason for this is that the npm package is outdated (i.e., it isn't updated by its authors when Google adds new icons). However, there is another, unofficial package that contains the new icons (and icon styles, too). Therefore, if the reason is indeed because the official package is outdated, do you recommend using the unofficial package, or should we use the official one instead? EDIT: the official developer guide from Google does not mention installing the icons through an npm package anymore, which I believe can be understood as Google ending their support for that package. Therefore, I will proceed using the unofficial package mentioned above. |
Should we support these? https://fonts.google.com/icons
Also, is it feasible?
The text was updated successfully, but these errors were encountered: