Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google Fonts Icons #1505

Closed
damithc opened this issue Mar 5, 2021 · 8 comments · Fixed by #1681
Closed

Support Google Fonts Icons #1505

damithc opened this issue Mar 5, 2021 · 8 comments · Fixed by #1681
Labels

Comments

@damithc
Copy link
Contributor

damithc commented Mar 5, 2021

Should we support these? https://fonts.google.com/icons
Also, is it feasible?

@damithc damithc added p.Low f-Icons Glyphicons etc labels Mar 5, 2021
@wxwxwxwx9
Copy link
Contributor

I think it's possible. Maybe we can explore implementing it as a plugin?

@damithc
Copy link
Contributor Author

damithc commented Mar 5, 2021

I think it's possible. Maybe we can explore implementing it as a plugin?

Support for other icon types are built-in. We can implement this as a plugin only if there is a good reason to differ from others. e.g., if adding this impose a significant performance cost, we can provide it as an optional feature (i.e., plugin)

@riyadh-h
Copy link
Contributor

Just checking if this issue is still active. Thank you.

@damithc
Copy link
Contributor Author

damithc commented Aug 23, 2021

@riyadh-h feel free to give it a try

@riyadh-h
Copy link
Contributor

riyadh-h commented Aug 25, 2021

So, I tried using these icons, and they don't seem to be aligned with any surrounding text:

google-material-icons

I assumed that the font size used for the icons was larger compared to the text's, so I tried resizing them to 18px.
However, this only worsened the render quality of the icons in my opinion:

google-material-icons-small

Do you think we should proceed with the original size, or is there another way to go about this?

@tlylt
Copy link
Contributor

tlylt commented Aug 25, 2021

Just curious... have you tried to align the icon via some CSS? (maybe some kind of vertical-align)

@riyadh-h
Copy link
Contributor

riyadh-h commented Aug 25, 2021

@tlylt Not really, but now that you've mentioned it, I tried giving the icons a vertical-align property that's set to bottom, and it looks perfect!

google-material-icons-works

Cheers 😄

EDIT: I'll use Bootstrap's align-middle class instead to align the icons 👍.

@riyadh-h
Copy link
Contributor

riyadh-h commented Aug 26, 2021

After some testing, I noticed that some icons aren't displayed on the rendered page when used.

For example, assume the syntax used looks similar to this:

# Google Material Icons

This is some text preceding the icon :google-work: and this succeeds it.

An:google-face:ther example.

:google-verified:

The resulting page looks like this:

example

As seen in the screenshot above, the verified icon, which looks like this:
image
isn't rendered on the page.

I believe the reason for this is that the npm package is outdated (i.e., it isn't updated by its authors when Google adds new icons). However, there is another, unofficial package that contains the new icons (and icon styles, too).

Therefore, if the reason is indeed because the official package is outdated, do you recommend using the unofficial package, or should we use the official one instead?

EDIT: the official developer guide from Google does not mention installing the icons through an npm package anymore, which I believe can be understood as Google ending their support for that package. Therefore, I will proceed using the unofficial package mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants