-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Google Fonts Icons #1681
Conversation
…ature-google-icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riyadh-h for working on this 😃. Tried it out and it looks good 👍
I might be missing something but it seems that the material-icons
package is only used within Markbind's core
package. I believe we can remove this dependency from the package.json of cli
, core-web
and vue-components
.
packages/cli/package.json
Outdated
@@ -37,6 +37,7 @@ | |||
"fs-extra": "^9.0.1", | |||
"live-server": "1.2.1", | |||
"lodash": "^4.17.15", | |||
"material-icons": "^1.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the material-icons
dependency from here since it does not seem to be used in this package? Same for core-web
and vue-components
.
Thank you for the review, @jonahtanjz, and I apologize for the late reply 😓
You're right, they are only used within the I'll try to remove them soon 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riyadh-h! :)
LGTM 👍
What is the purpose of this pull request?
Resolves #1505
Overview of changes:
Add support for Google's Material icons using the
material-icons
package.Anything you'd like to highlight / discuss:
The package used is not an official package by Google, since Google does not mention how the icons can be added as an npm package in the developer guide.
material-design-icons
npm package, but that package appears to be outdated in terms of including all icons and styles shown in the official icons' website. Thematerial-icons
npm package, however, is up-to-date with Google's latest set of icons and styles.Testing instructions:
n/a
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️
package-lock.json
files while adding thematerial-icons
npm package.