Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

se-book: panels/modals don't work in some pages #1588

Closed
damithc opened this issue Jun 16, 2021 · 3 comments · Fixed by #1592
Closed

se-book: panels/modals don't work in some pages #1588

damithc opened this issue Jun 16, 2021 · 3 comments · Fixed by #1592
Labels
c.Bug 🐛 p.Urgent To be done by next release, but follow normal release date

Comments

@damithc
Copy link
Contributor

damithc commented Jun 16, 2021

Code: https://github.com/damithc/se-book

Dynamic elements such as panels, modals, tooltips don't seem to work in some page. Here is an example:

image

Can't figure out the reason. They seem to work in other pages e.g., if I add a panel in the root page index.md, it seems to work.

@ang-zeyu
Copy link
Contributor

Untitled

@wxwxwxwx9 could you check this out? (removing popovers does the trick)
again, likely something site specific as it it seems to be working in markbind.org

@ang-zeyu ang-zeyu added c.Bug 🐛 p.Urgent To be done by next release, but follow normal release date labels Jun 16, 2021
@wxwxwxwx9
Copy link
Contributor

@ang-zeyu sorry for the late reply! Missed this during the weekday, will look into this!

@wxwxwxwx9
Copy link
Contributor

Screen Shot 2021-06-19 at 5 47 43 PM

@ang-zeyu It's a careless mistake from my side -- missed out adding the methods to the Vue initialization for sites which are not setup with search. Will make a PR to fix it!

@damithc thanks for raising this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug 🐛 p.Urgent To be done by next release, but follow normal release date
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants