Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appFactory to Vue initialization for setup #1592

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Add appFactory to Vue initialization for setup #1592

merged 1 commit into from
Jun 19, 2021

Conversation

wxwxwxwx9
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:
Resolves #1588. Added appFactory methods to Vue initialization for setup (which I missed when working on the SSR PR).

Anything you'd like to highlight / discuss:

Testing instructions:
npm run test

Proposed commit message: (wrap lines at 72 characters)
Add appFactory methods to Vue initialization for setup without search.

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No blatantly unrelated changes
  • Pinged someone for a review!

@wxwxwxwx9 wxwxwxwx9 merged commit 039a0ff into MarkBind:master Jun 19, 2021
@ang-zeyu ang-zeyu added this to the 3.0.3 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

se-book: panels/modals don't work in some pages
2 participants
@wxwxwxwx9 @ang-zeyu