Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the Convert feature, some links are not relative to the base url #1725

Closed
ong6 opened this issue Jan 18, 2022 · 0 comments · Fixed by #1728
Closed

When using the Convert feature, some links are not relative to the base url #1725

ong6 opened this issue Jan 18, 2022 · 0 comments · Fixed by #1728
Assignees

Comments

@ong6
Copy link
Contributor

ong6 commented Jan 18, 2022

Is your request related to a problem?

When using markbind init -convert I realized that some of the relative links do not have a baseUrl but others do.

No baseUrl:
image

With baseUrl:
image

This may cause issues when the user tries to deploy the webpage with the deploy feature some of the styles and links may not work as intended.

Describe the solution you'd like

Either add {{baseUrl}} to everything or remove it everywhere to keep things consistent.

I think adding baseUrl to everything makes more sense from a deployment perspective as that seems to be the main use case for people converting.

@ong6 ong6 self-assigned this Jan 18, 2022
@ong6 ong6 changed the title When using the convert Feature, all the some hrefs are not relative to the baseUrl When using the convert Feature, some hrefs are not relative to the baseUrl Jan 18, 2022
@ong6 ong6 changed the title When using the convert Feature, some hrefs are not relative to the baseUrl When using the Convert feature, some links are not relative to the base url Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant