Add relative links to the convert template file #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahtanjz
reviewed
Jan 19, 2022
| @@ -1,14 +1,14 @@ | |||
| <head-bottom> | |||
| <link rel="stylesheet" href="{{baseUrl}}/stylesheets/main.css"> | |||
| <link rel="stylesheet" href="{% raw%}{{baseUrl}}{% endraw %}/stylesheets/main.css"> | |||
There was a problem hiding this comment.
Trivial suggestion, able to add some spaces here? Same for the rest :)
Suggested change
| <link rel="stylesheet" href="{% raw%}{{baseUrl}}{% endraw %}/stylesheets/main.css"> | |
| <link rel="stylesheet" href="{% raw %}{{ baseUrl }}{% endraw %}/stylesheets/main.css"> |
|
@jonahtanjz Thanks for the tips! Will add them! |
ryoarmanda
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
LGTM! I'll leave the final reviewing and merge to @jonahtanjz.
ang-zeyu
pushed a commit
that referenced
this pull request
Jan 31, 2022
This reverts the package-lock changes from commit a539e2a.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #1725
Overview of changes:
This PR directly address the issue raised in #1725.
I fix it by adding the {{baseUrl}} into the template nunjucks file.
Anything you'd like to highlight / discuss:
Testing instructions:
Run
markbind init -con a test repo and see that the {{baseUrl}} is indeed there.Proposed commit message: (wrap lines at 72 characters)
Add relative links to template file
Checklist: ☑️