-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Refactoring work #1756
Comments
Related to #1495 |
Let me try researching this issue further - I'll post any updates / findings if I run into issues with decoupling and refactoring 😅 (Keeping this in mind: Completing TypeScript migration of The current plan is to refactor Update 1: After looking through The advantage of having command-specific managers: Update 2: After some preliminary refactoring and testing, it seems that with other files in TypeScript, it would be preferrable to not only have As a side note, I have identified |
Both general directions sound good. 👍 |
Is your request related to a problem?
Feels like the current core/site/index.js file is getting a little long (over 1.5k lines), making it hard to read and find important information, what is the general consensus around refactoring it?
Describe the solution you'd like
I propose we refactor the core/site/index.js file into all the different commands such as deploy, convert etc. Each command can be a separate class that contains its own functionality, while site can still exist as a the main driver class. This way, we can easily view all the code related to each command and make adding new commands easier.
Though I'm not sure how doable this is since everything looks very tightly coupled. Any suggestions or ideas on how to go about refactoring this would be great!
Describe alternatives you've considered
Nil
Additional context
Nil
The text was updated successfully, but these errors were encountered: