-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseUrl's value sometimes wrong when referencing inner website's content #262
Comments
Still investigating this issue. |
This commit replicates the bug in MarkBind/markbind#262.
@damithc FYI, the first issue (see below) can immediately be fixed by making changes on your side in I have found the fix for the second issue, and modified PR #263 accordingly. Will have to wait for that to be merged before the images work. 1. CSS url issueAffected webpage: Description: The URL to the CSS ( Why the Bug Exist: When using nunjucks' import feature, nunjucks will ignore any variables declared inside the imported file, unless it is specified to import the file "with context". Solution: If we want to use 2. Broken image issueAffected webpages: Description: The images are broken because the URL to the images are wrong (the Why the Bug Exist: I have traced down the issue to Solution: I have fixed the behavior, and the fix is in PR #263. The images will no longer be broken after the PR is merged. How the webpages look like after applying the fixes |
Yup, the CSS url issue worked. Thanks for finding the workaround 👍 |
v1.8.0 (not the latest version)
Consider this page:
https://github.com/nus-cs2103/website-base/edit/master/se-book-adapted/chapters/test.md
Rendered version:
https://nus-cs2103.github.io/website-base/se-book-adapted/chapters/test.html
It's the same content included twice, once directly (i.e., text.md#body), once indirectly (i.e., index.md). Surprisingly, the direct version has broken image links while the indirect version that goes through further variables, includes, and boilerplates seems to have the correct image links.
Any idea what's going on?
BTW, it works locally. The problem happens when I deploy.
The text was updated successfully, but these errors were encountered: