Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log website url on MarkBind deploy #844

Closed
amad-person opened this issue Apr 23, 2019 · 5 comments
Closed

Log website url on MarkBind deploy #844

amad-person opened this issue Apr 23, 2019 · 5 comments

Comments

@amad-person
Copy link
Contributor

amad-person commented Apr 23, 2019

Currently, the following message is shown on a successful deploy:

  __  __                  _      ____    _               _ 
 |  \/  |   __ _   _ __  | | __ | __ )  (_)  _ __     __| |
 | |\/| |  / _` | | '__| | |/ / |  _ \  | | | '_ \   / _` |
 | |  | | | (_| | | |    |   <  | |_) | | | | | | | | (_| |
 |_|  |_|  \__,_| |_|    |_|\_\ |____/  |_| |_| |_|  \__,_|
                                                           
 v2.3.0
info: Deployed!

Modifying the log message to info: Deployed at <URL> would allow users to navigate to the deployed site quickly.

Relevant code:

markbind/index.js

Lines 196 to 199 in 2a5e645

new Site(rootFolder, outputRoot, undefined, undefined, options.siteConfig).deploy(options.travis)
.then(() => {
logger.info('Deployed!');
})

@KendrickAng
Copy link
Contributor

Hi @ang-zeyu , could I take this issue as a first issue?

@ang-zeyu
Copy link
Contributor

yes, sure @KendrickAng. You might want to pick up where #947 left off as well if possible!

@KendrickAng
Copy link
Contributor

I'll take a look at it, thanks!

@KendrickAng
Copy link
Contributor

@ang-zeyu I believe this issue can be closed, or is there some policy we have regarding good-first-issues?

@ang-zeyu ang-zeyu closed this as completed Oct 8, 2020
@ang-zeyu
Copy link
Contributor

ang-zeyu commented Oct 8, 2020

resolved by #1329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants