-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji cdn links for markdown-it-emoji don't work #992
Comments
Can you clarify the issue? We aren't using markdown-it-emoji |
Edited with the source code, its the links in the defs for markdown-it-emoji that allows using Could have included it in first, my bad! |
Well TIL... |
Posted a working link by accident as well ( not sure if it’s the version that was being used before though ), apologies for the confusion! |
Seems like GitHub now uses native emoji for the numbers, these can be the replacement: 0️⃣ 1️⃣ 2️⃣ 3️⃣ 4️⃣ 5️⃣ 6️⃣ 7️⃣ 8️⃣ 9️⃣ |
What did you do? Please include the actual source code causing the issue.
markdown-it/index.js ( the fixed number defs for markdown-it-emoji )
Visit https://assets-cdn.github.com/images/icons/emoji/unicode/0030-20e3.png,
changing 0030 up to 0039 (inclusive), which are the urls used for the 0 - 9 emojis.
What did you expect to happen?
There are quite a few variants of 0 - 9 emojis around, so I'm not so sure which emojis exactly were used before as I never used them before in markbind.
The text was updated successfully, but these errors were encountered: