Change number emoji to use unicode characters #1016
Conversation
| @@ -1,15 +1,13 @@ | |||
| // fix emoji numbers | |||
| const emojiData = require('markdown-it-emoji/lib/data/full.json'); | |||
| // Extend emoji here | |||
| emojiData['zero'] = emojiData['0'] = '<img style="height: 1em;width: 1em;margin: 0 .05em 0 .1em;vertical-align: -0.1em;" src="https://assets-cdn.github.com/images/icons/emoji/unicode/0030-20e3.png">'; | |||
There was a problem hiding this comment.
It seems like we are also populating the digit key here (i.e. emojiData['1']) alongside the letter key, but we don't seem to do that in the new version. Is that intentional?
There was a problem hiding this comment.
Also I strongly encourage adopting the existing code's format (i.e. assigning each individual emoji line by line). The new changes disassociates the mapping between the names and the corresponding emoji.
There was a problem hiding this comment.
It seems like we are also populating the digit key here (i.e.
emojiData['1']) alongside the letter key, but we don't seem to do that in the new version. Is that intentional?
I did considering keeping the digit mapping for backwards compatibility. However, as they aren't standard emoji, and I could not find any current uses in the SE textbook and Markbind docs, I thought it would be better to remove them.
Also I strongly encourage adopting the existing code's format (i.e. assigning each individual emoji line by line). The new changes disassociates the mapping between the names and the corresponding emoji.
OK, I see your point. I will update the PR.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #992
What is the rationale for this request?
The links we use for number emoji (e.g. 1️⃣ ) from the Github CDN are no longer working, as they have changed to use unicode characters.
What changes did you make? (Give an overview)
Change the number emoji used in markdown-it-emoji to use unicode characters.
Proposed commit message: (wrap lines at 72 characters)
Number emojis in Markbind use the emoji images from Github's CDN.
Github has migrated to use unicode characters for their emojis, causing
our number emojis to break.
Let's update our number emojis to use the unicode characters as well.